Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Istanbul-lib-source-maps 1.0.2 #411

Merged
merged 1 commit into from
Oct 4, 2016
Merged

Conversation

mourner
Copy link
Contributor

@mourner mourner commented Oct 4, 2016

mind submitting the corresponding pull to nyc; I think that's the only other place we need to update?

@bcoe I assume you referred to a dependency bump?

@coveralls
Copy link

coveralls commented Oct 4, 2016

Coverage Status

Changes Unknown when pulling afb0ce2 on mourner:bump-source-maps into * on istanbuljs:master*.

@JaKXz
Copy link
Member

JaKXz commented Oct 4, 2016

Since it's a patch shouldn't it just be picked up automatically?

@mourner
Copy link
Contributor Author

mourner commented Oct 4, 2016

@JaKXz yes, but this should also in theory force an update if you do npm install, whereas without this you would need npm update. I think it doesn't hurt to update a patch dep if it contains a critical fix.

@JaKXz
Copy link
Member

JaKXz commented Oct 4, 2016

@mourner I agree - was just curious :)

@JaKXz JaKXz merged commit 9c89945 into istanbuljs:master Oct 4, 2016
@bcoe
Copy link
Member

bcoe commented Oct 4, 2016

@JaKXz @mourner fun fact, we bundle-dependencies on this repo:

  1. to improve install time (because our dependencies were getting pretty hefty).
  2. it fixes some singleton related issues; by moving things into a sub-folder (you end up with two copies of libraries, rather than one when using npm 3).

Long story short, we need to explicitly bump dependencies on nyc.

@alexander-akait
Copy link

@JaKXz @bcoe some problems with install [email protected] and [email protected]
I am try

rm -r node_modules/nyc
npm cache clean
npm i nyc

I get [email protected] but with [email protected], maybe someone from packages require [email protected] and we have istanbul-lib-source-maps: ^1.0.1, so I get not last version

@mourner
Copy link
Contributor Author

mourner commented Oct 5, 2016

@evilebottnawi there were no nyc release after this PR yet.

@alexander-akait
Copy link

@mourner understand it, and therefore I say that when you try to install [email protected], i got [email protected], not [email protected]

@mourner
Copy link
Contributor Author

mourner commented Oct 5, 2016

@evilebottnawi which is expected due to bundling of dependencies, as per #411 (comment)

@alexander-akait
Copy link

@mourner I should wait for a new version or it may be to solve?

@JaKXz
Copy link
Member

JaKXz commented Oct 7, 2016

@evilebottnawi I would suggest installing it from nyc@next to get the bug fix in and give it a spin :)

npm cache clear; npm i -D nyc@next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants